-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have in editor options to simulate common forms of color vision deficiency (color blindness) #21304
Comments
Okay, fixed. I think. |
Related to #15944. |
I think someone just watched the last GMTK video ;) I don't know if it is necessary as part of the engine, but it may be a great plugin for the library! |
The shaders to simulate these isn't at all complex (making the burden of maintaining them very small), but I definitely think it should be included by default to encourage devs to consider colorblind users and how their game looks to them. And yes, Mark Brown was definitely the inspiration! |
I remember Juan saying he didn't want to bloat the editor. But I do agree with you, it is a major concern. Would it be considered as bloating? I don't know... Anyway, either a plugin or an integrated option, here is the algorithm used by many tools online that I have encountered. 6 years ago I might have been able to understand everything but I haven't practiced mathematics since 2012 ;) |
Alright, I have studied more deeply the algorithms (it is not that hard actually). So, I think it is good to use the algorithm from (b.) For each pixel of color [R, G, B] (R, G and B in the interval [0,1]), we want to calculate the colorblind equivalent depending on the pathology :
Sources: |
I guess @paulloz was inspired by the same source: https://github.com/paulloz/godot-colorblindness |
Ha ha! This is going so fast! |
Haha yeah, I wanted to make something like this for a long time as I often struggle with some color choices in games I play. Mark's video was some kind of a reminder: now that I somehow know how to write a shader, I could finally do that. I'm currently implementing achromatopsia and will probably add some kind of strength parameter to be able to simulate more common types of colorblindness (e.g. deuteranomaly). @MattUV IINW I approximate linear space here. I'll have a look at your calculation and see if there's any major difference between the two. Thanks! Cheers all ❤️. Edit (an hour later): @MattUV indeed your formula for gamma correction handles dark tones a little better. Beware though, one of your values for RGB -> sRGB is off by a factor of ten :V |
I see you're hardcoding the gamme corrections. Is there currently no way to change the gamma value in the engine? |
As far as I know, no. It's possible to perform some adjustments and color correction in 3D using a WorldEnvironment node, but it only affects 3D rendering. |
@Calinou environment in Canvas mode makes effects to affect 2D too (including tonemap, glow, color adjustment). |
I think that the issue of contributing bloat is offset by how small colorblind shaders can be as well as the benefit of making developing for the disabled easier in Godot. Even if we ignore all the current issues with the asset library, having this as a plugin greatly diminishes the usefulness of it simply because it's something most people don't consider. Having it in editor and easily discoverable will make it much, much more likely that devs will use the tool and develop for the colorblind. |
Trust me, it's (sadly) not something most people will consider whether this is part of the engine or not. It's often not considered even if I'm right in front of the developers in a convention saying that their colour choices aren't right. |
@paulloz - I wouldn't say so. @Two-Tone is right that having it in the engine increases discoverability and thus, raises awareness that this issue even exists. I would argue that many game developers do not even think about something like color blindness. Having an option for a color blindness might be enough to get somebody to look into it. So I would strongly suggest putting it in the engine, even if its just to have feature parity with the Unreal Engine. |
Ported this over to godotengine/godot-proposals#473, closing here. |
A decent number of people suffer from being colorblind and as a result a lot of games are considerably harder or even impossible to play unless the devs specifically go out of their way to include colorblind modes.
My suggestion is to have toggles in the editor that lets the developer see what their game looks like if they had deuteranomaly, protanomaly, or tritanomly. It'll help the devs who want to create color blind modes by letting them see what those users would see.
The text was updated successfully, but these errors were encountered: