Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing syntax highlight setting does not update text highlighting #100431

Closed
Lunarexxy opened this issue Dec 15, 2024 · 1 comment · Fixed by #100451
Closed

Changing syntax highlight setting does not update text highlighting #100431

Lunarexxy opened this issue Dec 15, 2024 · 1 comment · Fixed by #100451

Comments

@Lunarexxy
Copy link

Lunarexxy commented Dec 15, 2024

Tested versions

Reproducible in v4.4.dev6.official [1f47e4c]
Reproducible in v4.4.dev2.official [97ef3c8]
Not reproducible in v4.4.dev1.official [28a72fa]
Not reproducible in Godot 4.3

System information

Godot v4.4.dev2 - Windows 10.0.19045 - OpenGL 3 (Compatibility) - NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.6590) - AMD Ryzen 7 4800H with Radeon Graphics (16 Threads)

Issue description

A very minor regression. When a text or script file is open, changing the syntax highlighting setting under Edit -> Syntax Highlighter -> [any setting] does not cause the text to use the new syntax highlighting, until some change in the text is made or the file is closed and reopened.

May be considered a duplicate of #98367, though that one is related to changing editor theme, while this one is about changing a script editor setting. Feel free to close if tracking one issue is easier.

Possibly caused by #92865.

Steps to reproduce

Create a text or script file and write something in it.
Open it in the built-in script editor.
Change Edit -> Syntax Highlighter to any option.
Notice no immediate change to syntax highlighting.
(if you edit the text, it will properly update)

Minimal reproduction project (MRP)

This project includes two text files, one .txt and one .gd, with mostly identical contents. File type doesn't seem to matter, though.

syntax_highlight_bug.zip

@Calinou
Copy link
Member

Calinou commented Dec 16, 2024

I can confirm this on 4.4.dev 9e60984.

@akien-mga akien-mga added this to the 4.4 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants