Close bracket is not generated when autocomplete

[tienlocnguyen]

Only open bracket is generated, closed bracket is not

Expect that close bracket will be generated too

[colludium]

Any update on this please? Thanks.

[atirut-w]

This is a very annoying issue but I've somehow forgotten about it. Maybe @DaelonSuzuka can fix this?

[Calinou]

Related to #142.

[DaelonSuzuka]

@atirut-w @Calinou Fixing this in the Language Server is a bit beyond my expertise at the moment. There are a number of other issues with both the Server(at least in 3.x) and the Client that I will eventually be addressing, but it's very complex system and that's going to take some time.

Luckily, I think there's a quick and dirty solution by just modifying the completions in the Client based on the context around the cursor/selection. If I have time this week, I'll try to put together a proof of concept.

[geekley]

Yes, this has been bothering me for quite a while.

Other languages in VSCode don't add any sort of parentheses on auto-completion, and this is what I expected for GDScript too. It's one of those things where doing too much automatically will be more trouble than help, and there's many reasons why:

• I don't always want a ( after accepting function suggestion. Often I want to pass its callback, so you shouldn't assume I want the parentheses and make me have to delete it, even if calling happens more often.
• Since it adds just a (, it makes the parentheses unbalanced.
• It's more trouble to delete the extra unbalanced (. For example, accepting a suggestion for function bar in this code: pass_callback(bar(|) (where | is the cursor), pressing backspace I want to delete the extra ( only, but it deletes both (). This is why is better to not assume and "try to help" too much adding parentheses.
• When I accept an auto-complete suggestion for a function, on other languages I type ( manually and automatically get the function signature popup without having to do CtrlShiftSpace. On GDScript, this doesn't happen, because it auto-fills the ( without triggering the parameter hints. So I still have to manually press MORE keys anyway (and add the closing ) afterwards).
• Being inconsistent with the behavior in other languages in VSCode is also a reason by itself.

So, please add at least an option to just not add any parentheses automatically.

[DaelonSuzuka]

@geekley

So, please add at least an option to just not add any parentheses automatically.

This behavior is controlled by the Language Server, which is a component of the Godot Engine itself. This extension does not control the completions, so there's nothing I can do about it.

[geekley]

@DaelonSuzuka is there an upstream issue which I can track then? So they add an option in the LSP?

[DaelonSuzuka]

I don't interact with the engine development, so I have no idea.

[geekley]

Found this, which I hope is the right issue, moved my comment there: godotengine/godot#86488 (comment)