Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the error line in the script editor minimap #987

Closed
Tracked by #40488
bjr29 opened this issue Jun 1, 2020 · 1 comment · Fixed by godotengine/godot#42775
Closed
Tracked by #40488

Highlight the error line in the script editor minimap #987

bjr29 opened this issue Jun 1, 2020 · 1 comment · Fixed by godotengine/godot#42775

Comments

@bjr29
Copy link

bjr29 commented Jun 1, 2020

Describe the project you are working on:
Making a raymarcher for other projects.

Describe the problem or limitation you are having in your project:
Little hard/ awkward to find the error sometimes.

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
Highlight the sidebar, showing all of the code in the code editor, red on the line the error occured.

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
Example

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Nope

Is there a reason why this should be core and not an add-on in the asset library?:
Its a small feature and don't think someone would really bother to make an add-on but it is a small quality of life thing I'd like and a few others will I think.

@poohcom1
Copy link

I think this feature can still be improved from an accessibility standpoint. For me the highlight on the minimap is barely visible (I'm slightly colorblind and I can barely really tell it apart from the current line highlight).

image

A workaround is to change the error highlight color to a more opaque and saturated color, but because it's shared with the main editor error highlight, it makes it obnoxiously bright in the editor.

I think having a separate color options for minimap errors that's more visible by default could be the simple fix, or maybe having the highlight appear over the text in the minimap.

On a side note: Having warnings appear in the minimap would be nice too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants