Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a confirmation dialog for moving folders in the FileSystem dock #7862

Open
ettiSurreal opened this issue Sep 25, 2023 · 3 comments
Open

Comments

@ettiSurreal
Copy link

ettiSurreal commented Sep 25, 2023

Describe the project you are working on

A simple platformer game, using a git repository to work across multiple devices.

Describe the problem or limitation you are having in your project

Currently it's very easy to accidentally move a file or a folder across the file system, which will often lead to having to search for what and where was moved, and at worst an engine crash. And there is no undo for moving files! I already had two situations where i had to discard an entire commit because i accidentally moved a large folder, which completely messed up references.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add a confirmation dialog for moving folders that aren't empty. Individual files are much less likely to be accidentally moved due to a misclick since dragging them on top of eachother does nothing, for that an undo function would work better.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

When trying to move a folder that isn't empty into another folder, you get a confirmation dialog, in which you can either cancel the move or confirm it.
I think there should not be a "don't show again" checkbox, as i feel like most users would think of it as a first-time warning, while this is supposed to prevent accidental moves due to misinput. Instead a way to disable it should be in editor settings if desired.

If this enhancement will not be used often, can it be worked around with a few lines of script?

I don't think it can.

Is there a reason why this should be core and not an add-on in the asset library?

Help users not cause accidental mess-ups.

@Calinou
Copy link
Member

Calinou commented Sep 25, 2023

Given moving a folder can take a long time to update references in a complex project, it makes sense to display a confirmation before this.

I wouldn't bother adding a setting to disable the confirmation unless there's a lot of demand for it though. (We need to keep the editor settings lean, and only add settings that people will really toggle on a regular basis.)

@produno
Copy link

produno commented Sep 25, 2023

To add to this, it may be a good idea to show in the confirmation box where the folder is being moved to. I have had at least a couple occasions where i thought i was moving a file to one location and it ended up somewhere else.

@74boar
Copy link

74boar commented May 17, 2024

This is my number 1 pain point with the engine. Mistakenly moving the wrong folder can break hundreds of dependencies at once. It should not be possible to suddenly corrupt an entire project by interacting with one of the most ubiquitous parts of the engine (e.g. navigating the project directory). And even if there was no danger of broken dependencies, I still think a confirmation dialog would be a good QOL feature to prevent moving a folder accidentally.

Alternatively, a setting to simply disable drag-click on folders would achieve the same goal. Knowing the danger, I never move files with drag-click, I always use right-click -> Move/Duplicate To...

@Calinou Calinou changed the title Add a confirmation dialog for moving folders in the file system. Add a confirmation dialog for moving folders in the FileSystem dock May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants