Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex Built-ins section in the Spatial Shaders documentation seems outdated #7502

Closed
lucho1 opened this issue Jun 12, 2023 · 0 comments · Fixed by #7510
Closed

Vertex Built-ins section in the Spatial Shaders documentation seems outdated #7502

lucho1 opened this issue Jun 12, 2023 · 0 comments · Fixed by #7510

Comments

@lucho1
Copy link

lucho1 commented Jun 12, 2023

Your Godot version: 4.0.3

URL to the documentation page: https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/spatial_shader.html#vertex-built-ins

Issue description: The Vertex Built-ins section in the Spatial Shaders documentation seems outdated at some points.

I was trying to use WORLD_NORMAL_MATRIX as it says in the doc linked, but apparently it was changed to MODEL_NORMAL_MATRIX in this PR. In there, they flagged out the need of updating the documentation and apparently they did it in this other PR, but it still looks outdated (at least for the built-in variable I tried to use, I didn't checked anything else).

In the PR where they changed the naming of those variables (the 1st I linked), someone flagged that the PR updating the related documentation (the 2nd I linked) only updated the fragment shader part of the docus but not the vertex one.

I'm creating this issue just to flag this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants