Skip to content

Commit 7c547c6

Browse files
authored
Merge pull request #1384 from allenwp/godot-87991-typed-array-additions
Added newer Variant types to `typed_array.hpp`
2 parents 36847f6 + 349b5a3 commit 7c547c6

File tree

2 files changed

+15
-0
lines changed

2 files changed

+15
-0
lines changed

include/godot_cpp/core/type_info.hpp

+6
Original file line numberDiff line numberDiff line change
@@ -370,11 +370,14 @@ MAKE_TYPED_ARRAY_INFO(Rect2i, Variant::RECT2I)
370370
MAKE_TYPED_ARRAY_INFO(Vector3, Variant::VECTOR3)
371371
MAKE_TYPED_ARRAY_INFO(Vector3i, Variant::VECTOR3I)
372372
MAKE_TYPED_ARRAY_INFO(Transform2D, Variant::TRANSFORM2D)
373+
MAKE_TYPED_ARRAY_INFO(Vector4, Variant::VECTOR4)
374+
MAKE_TYPED_ARRAY_INFO(Vector4i, Variant::VECTOR4I)
373375
MAKE_TYPED_ARRAY_INFO(Plane, Variant::PLANE)
374376
MAKE_TYPED_ARRAY_INFO(Quaternion, Variant::QUATERNION)
375377
MAKE_TYPED_ARRAY_INFO(AABB, Variant::AABB)
376378
MAKE_TYPED_ARRAY_INFO(Basis, Variant::BASIS)
377379
MAKE_TYPED_ARRAY_INFO(Transform3D, Variant::TRANSFORM3D)
380+
MAKE_TYPED_ARRAY_INFO(Projection, Variant::PROJECTION)
378381
MAKE_TYPED_ARRAY_INFO(Color, Variant::COLOR)
379382
MAKE_TYPED_ARRAY_INFO(StringName, Variant::STRING_NAME)
380383
MAKE_TYPED_ARRAY_INFO(NodePath, Variant::NODE_PATH)
@@ -393,8 +396,11 @@ MAKE_TYPED_ARRAY_INFO(Vector<String>, Variant::PACKED_STRING_ARRAY)
393396
MAKE_TYPED_ARRAY_INFO(Vector<Vector2>, Variant::PACKED_VECTOR2_ARRAY)
394397
MAKE_TYPED_ARRAY_INFO(Vector<Vector3>, Variant::PACKED_VECTOR3_ARRAY)
395398
MAKE_TYPED_ARRAY_INFO(Vector<Color>, Variant::PACKED_COLOR_ARRAY)
399+
MAKE_TYPED_ARRAY_INFO(IPAddress, Variant::STRING)
396400
*/
397401

402+
#undef MAKE_TYPED_ARRAY_INFO
403+
398404
#define CLASS_INFO(m_type) (GetTypeInfo<m_type *>::get_class_info())
399405

400406
} // namespace godot

include/godot_cpp/variant/typed_array.hpp

+9
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ class TypedArray : public Array {
7575
} \
7676
};
7777

78+
// All Variant::OBJECT types are intentionally omitted from this list because they are handled by
79+
// the unspecialized TypedArray definition.
7880
MAKE_TYPED_ARRAY(bool, Variant::BOOL)
7981
MAKE_TYPED_ARRAY(uint8_t, Variant::INT)
8082
MAKE_TYPED_ARRAY(int8_t, Variant::INT)
@@ -94,11 +96,14 @@ MAKE_TYPED_ARRAY(Rect2i, Variant::RECT2I)
9496
MAKE_TYPED_ARRAY(Vector3, Variant::VECTOR3)
9597
MAKE_TYPED_ARRAY(Vector3i, Variant::VECTOR3I)
9698
MAKE_TYPED_ARRAY(Transform2D, Variant::TRANSFORM2D)
99+
MAKE_TYPED_ARRAY(Vector4, Variant::VECTOR4)
100+
MAKE_TYPED_ARRAY(Vector4i, Variant::VECTOR4I)
97101
MAKE_TYPED_ARRAY(Plane, Variant::PLANE)
98102
MAKE_TYPED_ARRAY(Quaternion, Variant::QUATERNION)
99103
MAKE_TYPED_ARRAY(AABB, Variant::AABB)
100104
MAKE_TYPED_ARRAY(Basis, Variant::BASIS)
101105
MAKE_TYPED_ARRAY(Transform3D, Variant::TRANSFORM3D)
106+
MAKE_TYPED_ARRAY(Projection, Variant::PROJECTION)
102107
MAKE_TYPED_ARRAY(Color, Variant::COLOR)
103108
MAKE_TYPED_ARRAY(StringName, Variant::STRING_NAME)
104109
MAKE_TYPED_ARRAY(NodePath, Variant::NODE_PATH)
@@ -116,6 +121,10 @@ MAKE_TYPED_ARRAY(PackedStringArray, Variant::PACKED_STRING_ARRAY)
116121
MAKE_TYPED_ARRAY(PackedVector2Array, Variant::PACKED_VECTOR2_ARRAY)
117122
MAKE_TYPED_ARRAY(PackedVector3Array, Variant::PACKED_VECTOR3_ARRAY)
118123
MAKE_TYPED_ARRAY(PackedColorArray, Variant::PACKED_COLOR_ARRAY)
124+
// If the IPAddress struct is added to godot-cpp, the following could also be added:
125+
//MAKE_TYPED_ARRAY(IPAddress, Variant::STRING)
126+
127+
#undef MAKE_TYPED_ARRAY
119128

120129
} // namespace godot
121130

0 commit comments

Comments
 (0)