Skip to content

Commit 738859f

Browse files
committed
removes warnings generated by GDCLASS usage
This change removes the warnings (unused parameters) coming from code injected by the GDCLASS macro. Contrary to warnings coming from the normal source code which can be suppressed with most compiles by specifying the include directories of this library as external or system, when the code is injected through a macro it is considered in the context of the user, which is the source code of user of the library. That forces the users to modify their code to hide the warnings coming from the mandatory `GDCLASS` here. That's why it's important to remove these warning from that specific macro and ideally any other macro that the user must use.
1 parent 9da1e0c commit 738859f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

include/godot_cpp/classes/wrapped.hpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ struct EngineClassRegistration {
179179
// every line of the macro different
180180
#define GDCLASS(m_class, m_inherits) /***********************************************************************************************************************************************/ \
181181
private: \
182-
void operator=(const m_class &p_rval) {} \
182+
void operator=(const m_class & /*p_rval*/) {} \
183183
friend class ::godot::ClassDB; \
184184
friend class ::godot::Wrapped; \
185185
\
@@ -316,7 +316,7 @@ public:
316316
return ::godot::internal::create_c_property_list(plist_cpp, r_count); \
317317
} \
318318
\
319-
static void free_property_list_bind(GDExtensionClassInstancePtr p_instance, const GDExtensionPropertyInfo *p_list, uint32_t p_count) { \
319+
static void free_property_list_bind(GDExtensionClassInstancePtr p_instance, const GDExtensionPropertyInfo *p_list, uint32_t /*p_count*/) { \
320320
if (p_instance) { \
321321
m_class *cls = reinterpret_cast<m_class *>(p_instance); \
322322
cls->plist_owned.clear(); \
@@ -373,22 +373,22 @@ public:
373373
} \
374374
} \
375375
\
376-
static void free(void *data, GDExtensionClassInstancePtr ptr) { \
376+
static void free(void * /*data*/, GDExtensionClassInstancePtr ptr) { \
377377
if (ptr) { \
378378
m_class *cls = reinterpret_cast<m_class *>(ptr); \
379379
cls->~m_class(); \
380380
::godot::Memory::free_static(cls); \
381381
} \
382382
} \
383383
\
384-
static void *_gde_binding_create_callback(void *p_token, void *p_instance) { \
384+
static void *_gde_binding_create_callback(void * /*p_token*/, void * /*p_instance*/) { \
385385
return nullptr; \
386386
} \
387387
\
388-
static void _gde_binding_free_callback(void *p_token, void *p_instance, void *p_binding) { \
388+
static void _gde_binding_free_callback(void * /*p_token*/, void * /*p_instance*/, void * /*p_binding*/) { \
389389
} \
390390
\
391-
static GDExtensionBool _gde_binding_reference_callback(void *p_token, void *p_instance, GDExtensionBool p_reference) { \
391+
static GDExtensionBool _gde_binding_reference_callback(void * /*p_token*/, void * /*p_instance*/, GDExtensionBool /*p_reference*/) { \
392392
return true; \
393393
} \
394394
\

0 commit comments

Comments
 (0)