Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When cloning a remote repo, config should be read from its pyproject.toml #18

Closed
tarkatronic opened this issue Nov 15, 2019 · 0 comments · Fixed by #24
Closed

When cloning a remote repo, config should be read from its pyproject.toml #18

tarkatronic opened this issue Nov 15, 2019 · 0 comments · Fixed by #24
Labels
enhancement New feature or request

Comments

@tarkatronic
Copy link
Contributor

We will soon be able to read default configuration from a local pyproject.toml file, but this leaves a bit of a gap:

When you invoke tartufo with a git_url, it will clone that url into a local folder, and then scan that folder. But if that repo contains a pyproject.toml with a [tool.tartufo] section, we don't respect any of those options.

I don't think it makes sense, in this scenario, to read all options. But I think it does make sense to scan select options. The options I think we should attempt to read are:

  • rules -- files containing regexes
  • include-files -- Files to be included in the scan
  • exclude-files -- Files to be excluded from the scan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant