You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for pointing this out @nicolad. Is there any particular reason we should do it like core has for the Columns block?
With replaceInnerBlocks it is easier to reason about the fact that the context is related to nested blocks. ATM I am not aware of implementation differences, but will dive deeper as I will progress on core social links block PR.
@nicolad Thank you for the contribution of bringing ideas to the table. Do you have any followup with this? Ill go ahead and close the issue if this is a question for a later date.
Is this enhancement related to a problem? Please describe.
When I started implementing social links for GB I took some inspiration from coblocks' accordion, more specific - the approach of adding new accordion item: https://github.com/godaddy/coblocks/blob/master/src/blocks/accordion/components/edit.js#L113
Describe the solution you'd like
Later I observed that in
columns
block of GB there is a different approach on adding nesting blocks items: https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/columns/edit.js#L215Any thoughts?
The text was updated successfully, but these errors were encountered: