Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting collations need adjustment #864

Closed
dveeden opened this issue May 6, 2024 · 2 comments · Fixed by #865
Closed

Setting collations need adjustment #864

dveeden opened this issue May 6, 2024 · 2 comments · Fixed by #865

Comments

@dveeden
Copy link
Collaborator

dveeden commented May 6, 2024 •
edited
Loading

Follow-up for #860

See also:

What is needed is that we set the collation in the handshake as 1 byte if the collation <=255 and that we send a SET NAMES ... COLLATE ... if the collation >255.

cc @lance6716 @dvilaverde
@dvilaverde dvilaverde mentioned this issue May 6, 2024
Merged
@dvilaverde
Copy link
Contributor

I hope #865 addresses this issue.

@dveeden dveeden linked a pull request May 7, 2024 that will close this issue
collation in auth handshake are 1-byte #865
Merged
@dveeden
Copy link
Collaborator Author

dveeden commented May 7, 2024

Thanks @dvilaverde !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

collation in auth handshake are 1-byte dvilaverde/go-mysql
2 participants
@dveeden @dvilaverde