Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When requesting captcha, it will request database. #7408

Closed
lunny opened this issue Jul 10, 2019 · 5 comments
Closed

When requesting captcha, it will request database. #7408

lunny opened this issue Jul 10, 2019 · 5 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@lunny
Copy link
Member

lunny commented Jul 10, 2019

2019/07/10 09:51:03 Started GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 for [::1]
2019/07/10 09:51:03 .../xorm/session_get.go:99:nocacheGet() [I] [SQL] SELECT `id`, `lower_name`, `name`, `full_name`, `email`, `keep_email_private`, `passwd`, `passwd_hash_algo`, `must_change_password`, `login_type`, `login_source`, `login_name`, `type`, `location`, `website`, `rands`, `salt`, `language`, `description`, `created_unix`, `updated_unix`, `last_login_unix`, `last_repo_visibility`, `max_repo_creation`, `is_active`, `is_admin`, `allow_git_hook`, `allow_import_local`, `allow_create_organization`, `prohibit_login`, `avatar`, `avatar_email`, `use_custom_avatar`, `num_followers`, `num_following`, `num_stars`, `num_repos`, `num_teams`, `num_members`, `visibility`, `diff_view_style`, `theme` FROM `user` WHERE `lower_name`=? LIMIT 1 []interface {}{"captcha"}
2019/07/10 09:51:03 Completed GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 200 OK in 119.484905ms

When a middleware has written something to ResponseWriter, it should not go to match the URL? Is this a bug of macaron or our wrong configuration?

@lunny lunny added the type/bug label Jul 10, 2019
@zeripath
Copy link
Contributor

Was this fixed by #7407?

@lunny
Copy link
Member Author

lunny commented Jul 10, 2019

I think no.

@stale
Copy link

stale bot commented Sep 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 8, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 10, 2019
@stale stale bot removed the issue/stale label Sep 10, 2019
@lunny
Copy link
Member Author

lunny commented Sep 10, 2019

I will check if this is still in v1.10.

@lunny
Copy link
Member Author

lunny commented Sep 12, 2019

This has gone on 1.10.0+dev-277-g5e67e0100

@lunny lunny closed this as completed Sep 12, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

2 participants