Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Accessbilty/Contrast in dark theme #6687

Closed
xf- opened this issue Apr 19, 2019 · 10 comments
Closed

Increase Accessbilty/Contrast in dark theme #6687

xf- opened this issue Apr 19, 2019 · 10 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI

Comments

@xf-
Copy link
Contributor

xf- commented Apr 19, 2019

Description

The contrast between background and font is low in dark theme. It is really exhausting using it. Depending on display/backlight and also features like "Low Blue Light" make sometimes hard to read the content. Compared to other dark themes the background is bright and font gray.
I like dark themes like YouTube or KDE breeze dark skin.

My suggestion wold be Lighthouse accessibility tool to test color contrast.
image
https://github.com/GoogleChrome/lighthouse/
Also used in Google insight

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 25, 2019
@stale
Copy link

stale bot commented Jun 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 24, 2019
@xf-
Copy link
Contributor Author

xf- commented Jun 25, 2019

Should be improved @bot :P

@stale stale bot removed the issue/stale label Jun 25, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 25, 2019
@BNolet
Copy link
Contributor

BNolet commented Jul 31, 2019

As well, here:
image

@Jieiku
Copy link

Jieiku commented Apr 13, 2022

I actually had some issues reading with the current contrast, so I made a new theme yesterday.
I may make more small tweaks as I notice other contrast issues.

https://github.com/Jieiku/theme-dark-arc-gitea

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 5, 2022

@silverwind Would you be able to help me the source for the arc-green theme? As in: where did you find the values for the Less file?

https://github.com/go-gitea/gitea/blob/73382d2132f8f242245d83f66c92761e0b477b91/web_src/less/themes/theme-arc-green.less

I noticed that the file is around for a long time, but you seem to have the most familiarity with it.

KDE Breeze Dark colour palette is defined in https://develop.kde.org/hig/style/color/dark/

@Ryuno-Ki
Copy link
Contributor

@TTWNO We touched the topic on Matrix before. Do you have ideas here?

@HubKing
Copy link

HubKing commented Nov 17, 2022

I hate that most dark themes (not just Gitea) are low-contrast. I don't know; maybe other people like it that way, but low-contrast dark themes defeat the purpose of dark theme. The background is still bright hurting my eyes, and the text is too dark to read when my monitor is set to the minimum brightness. To read the text, I would have to increase the monitor brightness, further scorching my eyes.

Can't you just add another in-built theme, "high-contrast dark"? Refer to IntelliJ (Android Studio or any similar IDE).
image

@silverwind
Copy link
Member

I plan to make a proper dark theme now that all colors are in CSS variables. After that is done, we can talk about high-contrast themes that would probably build on the default light/dark themes.

@wxiaoguang
Copy link
Contributor

The dark theme has changed a lot, I guess this issue could be closed?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 25, 2023
@silverwind
Copy link
Member

silverwind commented Apr 25, 2023

Yes, I think current dark theme has enough contrast. I have not ran WCAG on it yet, but I assume it'll be close to passing those tests.

Proper "black" theme I would still like to do but we need infrastructure to support multiple dark/light themes in backend.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests

9 participants