Repo indexer not searching some method names

[mcdamo]

• Gitea version (or commit ref): 1.6.3
• Git version:
• Operating system: FreeBSD
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant (indexer not enabled)
• Log gist:

Description

I have code like $e->getMessage() but the indexer cannot search 'getMessage'.
To find this code I must search '*Message', but obviously that example brings up many unwanted results.

Code like $this->method() can be searched with 'method' so perhaps the indexer is splitting the camelcase words.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[mcdamo]

Possibly related #5277 (cannot search snake_case)

[guillep2k]

Same here. For instance, I search for "main" and I get quite a few hits, but none of them is a main() function which I'm certain exists. It's not only a camel case problem, apparently. Also, it's not necessarily an index problem, but perhaps a retrieval problem?

But:

One might think: it's indexing Mon and Console separately, but with other words it works half-fine:

Here the .h definition is correctly found, but the corresponding .c implementation is not.

[guillep2k]

I made some tests, and the culprit is here, in modules/indexer/repo.go. It's explicitly calling for a camel case converter in the token_filters slice:

I'm sure there are cases where this is very much the desired behaviour, but it surely isn't what I was expecting. I tried removing camelcase.Name from the list and it's working for me, now.
A switch to choose the desired behaviour could be implemented as a setting in app.ini, but the previous indexes must be dropped and recreated if the setting is changed after the fact. An option to re-build the repo indexes in the Maintenance Operations section of /admin would be handy.

[mrsdizzie]

Should be fixed from #7733