Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook pull_request synchronize action field is synchronized, but github is synchronize #27118

Open
Yiklek opened this issue Sep 18, 2023 · 3 comments
Labels

Comments

@Yiklek
Copy link

Yiklek commented Sep 18, 2023

Description

gitea:
image

github: https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=synchronize#pull_request

I use @octokit/webhooks. It works by listening on pull_request.synchronized, but it reports:

"pull_request.synchronized" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)

So is it possible to keep these events compatible with github?

Gitea Version

47b8788

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build on 47b8788

Database

None

@Yiklek
Copy link
Author

Yiklek commented Sep 18, 2023

By the way, after a reviewer requests change, the reviewer is not removed from requested_reviewers in webhook payload.
But github docs says:

Once a requested reviewer submits a review, they are no longer considered a requested reviewer.

@lng2020
Copy link
Member

lng2020 commented Sep 18, 2023

By the way, after a reviewer requests change, the reviewer is not removed from requested_reviewers in webhook payload. But github docs says:

Once a requested reviewer submits a review, they are no longer considered a requested review

pr(#27104) will fix this one

@Yiklek
Copy link
Author

Yiklek commented Sep 18, 2023

Other issues about review:

  1. Review state in webhook payload. Github is CHANGES_REQUESTED, but gitea is REQUEST_CHANGES.
  2. Review state in webhook payload. After dismissing a review, state should be DISMISSED, but gitea does not change this field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants