Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask for Changing alt Property of Logo img Element #19950

Closed
Orange23333 opened this issue Jun 12, 2022 · 3 comments · Fixed by #19955
Closed

Ask for Changing alt Property of Logo img Element #19950

Orange23333 opened this issue Jun 12, 2022 · 3 comments · Fixed by #19955
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@Orange23333
Copy link

Feature Description

A little suggestion:

Change from
<img class="ui mini image" width="30" height="30" src="/assets/img/logo.svg" alt="Logo">
to
<img class="ui mini image" width="30" height="30" src="/assets/img/logo.svg" alt="Home Page">
is more pretty nice for understanding, including but not limited to blind.

By the way, If you use SVG format, could consult GitHub code. They use aria-label property:

<a href="https://github.com/" aria-label="Homepage "><svg></svg></a>

And GitLab use aria-label and a tooltip with text GitLab home page:

<a href="/" data-nav="logo" aria-label="Home" class="slp-btn slp-mr-8 slp-btn-icon" ><svg xmlns="http://www.w3.org/2000/svg" role="img" aria-labelledby="tanukiHomeDesktop"><title id="tanukiHomeDesktop">GitLab home page</title></svg></a>

But for lightness, aria-label property is great and enough.

Thanks a lot!

Screenshots

No response
@Orange23333 Orange23333 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 12, 2022
@wxiaoguang wxiaoguang mentioned this issue Jun 13, 2022
Merged
@wxiaoguang
Copy link
Contributor

Try this

@Orange23333
Copy link
Author

Nice!

@wxiaoguang
Copy link
Contributor

ps: it's still being reviewed. Wait for some time for its merge.

@6543 6543 reopened this Jun 13, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix aria for logo wxiaoguang/gitea
3 participants
@wxiaoguang @Orange23333 @6543