Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid page reloads on unchanged assignee/labels #12783

Closed
silverwind opened this issue Sep 9, 2020 · 5 comments
Closed

Avoid page reloads on unchanged assignee/labels #12783

silverwind opened this issue Sep 9, 2020 · 5 comments
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@silverwind
Copy link
Member

silverwind commented Sep 9, 2020

STR:

  1. View any issue
  2. Double click on "Assignees" or "Labels" in the sidebar, e.g. don't change anything
  3. Page unnecessarily reloads

Should ideally also eliminate the page reloads when values actually change and just update DOM accordingly in JS.

@lunny lunny added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Sep 10, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 9, 2020
@silverwind
Copy link
Member Author

👍

@jolheiser
Copy link
Member

This is mostly fixed by #23014
It doesn't cover the "update the DOM" case, please re-open if you think it should be part of this issue or if we should have a specific issue for it now that this is partially fixed.

@wxiaoguang
Copy link
Contributor

I also agree to "just update DOM accordingly in JS", but those dropdowns are much more complex than I thought, so I left them as they were. To touch them .... it needs another (big) refactoring PR.

@silverwind
Copy link
Member Author

silverwind commented Mar 17, 2023

Should probably rewrite them in Vue/React/... 😉

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants