CORS doesn't work

[guerinoni]

To Reproduce
Steps to reproduce the behavior:

Take the basic example and just add

	fuego.Use(s, cors.New(cors.Options{
		AllowedOrigins: []string{"*"},
		AllowedMethods: []string{"GET", "POST", "PUT", "DELETE", "OPTIONS"},
		AllowedHeaders: []string{"*"},
	}).Handler)

Expected behavior
I have a front end running on localhost:3000 and hitting backend in localhost:8080, I got the error about missing CORS.

If I switch to another example i tried without fuego it is working

server := http.Server{
                Addr: "127.0.0.1:8080",
                Handler: cors.New(cors.Options{
                        AllowedOrigins: []string{"http://localhost:3000"},
                        AllowedMethods: []string{"GET", "POST", "PUT", "DELETE"},
                }).Handler(mux),
        }

Screenshots

Framework version (please check if it happens with the last Fuego version before posting):
Latest 0.12

Go version (please check if it happens with the last Go version before posting):
Latest: go version go1.22.0 darwin/arm64

[EwenQuim]

Hi @guerinoni !

Are your routes declared before or after the middleware registration ?

[guerinoni]

Hi @guerinoni !

Are your routes declared before or after the middleware registration ?

Does not matter, i see the same problem

[guerinoni]

func (s *Server) Run() error {
	go s.generateOpenAPI()
	elapsed := time.Since(s.startTime)
	slog.Debug("Server started in "+elapsed.String(), "info", "time between since server creation (fuego.NewServer) and server startup (fuego.Run). Depending on your implementation, there might be things that do not depend on fuego slowing start time")
	slog.Info("Server running ✅ on http://localhost"+s.Server.Addr, "started in", elapsed.String())

	s.Server.Handler = cors.New(cors.Options{
		AllowedOrigins: []string{"*"},
		AllowedMethods: []string{"GET", "POST", "PUT", "DELETE"},
		AllowedHeaders: []string{"*"},
	}).Handler(s.Mux)

	return s.Server.ListenAndServe()
}

This fixes the problem

[EwenQuim]

Sorry I cannot reproduce.

I noticed having CORS issues when having a 405 response, is it your case ?

[EwenQuim]

I can help you solve your CORS issue if you want, but I don't think it is related to the framework, it works in my case!

---

Result on a React app:
Notice that the Access-Control-Allow-Origin is correctly set.

Code:

[guerinoni]

I'm not able to make it work, can you attach your front end application? I can try with your code

[EwenQuim]

Can you show me the network error ? I want to see the preflight request

[guerinoni]

[EwenQuim]

This is a 405 return code, are you sure that you are calling the correct METHOD for the /signup route?