Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fuego Error for PathParam errors #386

Open
dylanhitt opened this issue Feb 5, 2025 · 7 comments
Open

Use fuego Error for PathParam errors #386

dylanhitt opened this issue Feb 5, 2025 · 7 comments
Labels
feature-request New feature or request
Milestone
v0.19

Comments

@dylanhitt
Copy link
Collaborator

Per this comment: #381 (comment)

The PathParamInvalidTypeError should be wrapped up by a fuego.BadRequest error

The QueryParamInvalidTypeError should do the same https://github.com/go-fuego/fuego/blob/main/internal/common_context.go#L122.
@EwenQuim EwenQuim added this to the v0.19 milestone Feb 5, 2025
@EwenQuim EwenQuim added the feature-request New feature or request label Feb 5, 2025
@jancris100
Copy link

Hey! I'm Jan.
Member of Dojo Coding. I have contributed before to other projects like:

• Dojo
• Go Stark Me
Can I work on this issue?

@EwenQuim
Copy link
Member

EwenQuim commented Feb 5, 2025

Yeah if you want!

Please think about adding some tests.

@jancris100
Copy link

Do I need to modify only the internal/common_context.go file, or should I update all references in other files where PathParamInvalidTypeError and QueryParamInvalidTypeError appear, replacing them with fuego.BadRequest?

@EwenQuim
Copy link
Member

EwenQuim commented Feb 6, 2025

Please remove completely PathParamInvalidTypeError and QueryParamInvalidTypeError

@B-uchi
Copy link

B-uchi commented Feb 9, 2025

May I pick this up?

@EwenQuim
Copy link
Member

EwenQuim commented Feb 9, 2025

Yes if you want!

@EwenQuim
Copy link
Member

@jancris100 @B-uchi any nesw on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
v0.19
Development

No branches or pull requests
4 participants
@dylanhitt @EwenQuim @jancris100 @B-uchi