Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): wrong module name of nestedpkg #2522

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

linhpn99
Copy link
Contributor

@linhpn99 linhpn99 commented Jul 6, 2024

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@linhpn99 linhpn99 requested review from a team as code owners July 6, 2024 15:09
@linhpn99 linhpn99 requested review from sw360cab and deelawn and removed request for a team July 6, 2024 15:09
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 6, 2024
@linhpn99
Copy link
Contributor Author

linhpn99 commented Jul 6, 2024

@moul I noticed that in some of the older packages you merged, it seems you forgot to configure the full path correctly for the module name: gno.land/p/demo/xxx instead of just xxx. This will cause a runtime error if any package or realm imports this package

@zivkovicmilos zivkovicmilos merged commit 30c6368 into gnolang:master Jul 6, 2024
9 checks passed
@linhpn99 linhpn99 deleted the hotfix-nestedpkg branch July 6, 2024 16:11
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants