From 63d9c7f9a319f90be57c9f717bdaa3c8a10ce7d9 Mon Sep 17 00:00:00 2001 From: rustlang-dev Date: Mon, 16 Sep 2024 07:59:45 +0100 Subject: [PATCH 1/2] fix run of Subcommand::FrontierDb --- node/src/command.rs | 5 ++--- node/src/service.rs | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/node/src/command.rs b/node/src/command.rs index 8df03e274..de267e592 100644 --- a/node/src/command.rs +++ b/node/src/command.rs @@ -240,11 +240,10 @@ pub fn run() -> sc_cli::Result<()> { let (client, _, _, _, frontier_backend) = service::new_chain_ops(&mut config, &cli.eth)?; let frontier_backend = match frontier_backend { - fc_db::Backend::KeyValue(kv) => std::sync::Arc::new(kv), + fc_db::Backend::KeyValue(kv) => kv, _ => panic!("Only fc_db::Backend::KeyValue supported"), }; - // cmd.run(client, *frontier_backend) - todo!();// ^ uncomment this line + cmd.run(client, frontier_backend) }) } None => { diff --git a/node/src/service.rs b/node/src/service.rs index c37caa990..6bdf025a5 100644 --- a/node/src/service.rs +++ b/node/src/service.rs @@ -807,7 +807,6 @@ where // and vote data availability than the observer. The observer has not // been tested extensively yet and having most nodes in a network run it // could lead to finality stalls. - todo!(); let grandpa_voter = sc_consensus_grandpa::run_grandpa_voter(sc_consensus_grandpa::GrandpaParams { config: grandpa_config, From a0835eaacc9b894797722c9cd09d2d7824172c9e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 16 Sep 2024 07:00:42 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- node/src/service.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/node/src/service.rs b/node/src/service.rs index 6bdf025a5..7e72df219 100644 --- a/node/src/service.rs +++ b/node/src/service.rs @@ -475,7 +475,7 @@ where let warp_sync_params = if sealing.is_some() { None } else { - + net_config.add_notification_protocol(grandpa_protocol_config); let warp_sync: Arc> = Arc::new(sc_consensus_grandpa::warp_proof::NetworkProvider::new(