Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple selection tickbox needs a re-think #125

Closed
philipjackson opened this issue Jun 29, 2021 · 3 comments
Closed

Multiple selection tickbox needs a re-think #125

philipjackson opened this issue Jun 29, 2021 · 3 comments
Labels
duplicate [Inactive] This issue or pull request already exists.

Comments

@philipjackson
Copy link
Contributor

The only effect of the "Select Multiple Images" button is to produce a delete button. It doesn't affect the ability to select multiple images; that is done by ctr/shift clicking with or without the tickbox activated.

We need to display the delete button whenever any images are selected, regardless of if the "select multiple" box is checked. In which case, the only remaining purpose for the "select multiple" box would have no remaining purpose, and we should just replace it with a delete button that's always there. Or we could leave it in and have it enable single-click multiple selections (which it currently does not do), giving users a way to select multiple without using the keyboard.

@RoseBunker
Copy link

Thanks for explanation above. I picked up on this yesterday. I wrote in my notes:

"“Select multiple images” doesn’t do what I thought it would. What difference does this button make to selecting the thumbnails I want, because I still have to hold Ctrl to select multiple?"

@ChasNelson1990
Copy link
Member

@joshuajames-smith can we mark this as duplicate and close (as it's covered by #228)?

@joshuajames-smith joshuajames-smith added the duplicate [Inactive] This issue or pull request already exists. label Jan 6, 2022
@joshuajames-smith
Copy link
Contributor

@joshuajames-smith can we mark this as duplicate and close (as it's covered by #228)?

Yes it's now a duplicate and I will have labelled this and will close!

@joshuajames-smith joshuajames-smith closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate [Inactive] This issue or pull request already exists.
Projects
None yet
Development

No branches or pull requests

4 participants