Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong font filename in compiled stylesheet #17

Closed
cah4a opened this issue Oct 14, 2015 · 7 comments · Fixed by #18
Closed

Wrong font filename in compiled stylesheet #17

cah4a opened this issue Oct 14, 2015 · 7 comments · Fixed by #18

Comments

@cah4a
Copy link
Contributor

cah4a commented Oct 14, 2015

Console output:

WARNING: 'icon-preview.eot?' was not found (or cannot be read) in project/web/theme/fonts
WARNING: 'icon-preview.woff' was not found (or cannot be read) in project/web/theme/fonts
WARNING: 'icon-preview.ttf' was not found (or cannot be read) in project/web/theme/fonts
WARNING: 'icon-preview.svg' was not found (or cannot be read) in project/web/theme/fonts

Generated stylesheet:

@font-face {
  font-family: "icon";
  src: url('../fonts/icon-preview.eot?#iefix') format('embedded-opentype'), url('../fonts/icon-preview.woff') format('woff'), url('../fonts/icon-preview.ttf') format('truetype'), url('../fonts/icon-preview.svg#icon') format('svg');
  font-weight: normal;
  font-style: normal;
}

System: MacOs

@cah4a
Copy link
Contributor Author

cah4a commented Oct 14, 2015

Looks like GlyphMap::filename method can return wrong file such as demo-font-preview.html which causes font links in stylesheet are broken.

I see that bug is in the GlyphMap class at method

def glob
    glob = File.join output_dir, "#{self.name}*"
    Dir[glob]
end

@vladislavs
Copy link

why it still not merged?

@cah4a
Copy link
Contributor Author

cah4a commented Jan 29, 2017

Because nobody cares, i guess

You can use my fork if you want to.
Just add this to Gemfile:

gem 'compass-fontcustom', :git => 'https://github.com/cah4a/compass-fontcustom.git', :branch => 'codepoints-support'

@vladislavs
Copy link

Seems, someone does care. 👍 Thank you both!

@cah4a
Copy link
Contributor Author

cah4a commented Jan 31, 2017

Yeah! Cool)

@glaszig
Copy link
Owner

glaszig commented Jan 31, 2017

this library is not on my radar anymore. even less so since fontcustom itself has been abandoned (FontCustom/fontcustom#321). supposedly there's javascript-based build tools for the job.

however, i've spent half the day trying to get travis to deploy a new version to rubygems. i did it for another gem but this time it doesn't work.

@glaszig
Copy link
Owner

glaszig commented Jan 31, 2017

alright. version 1.3.1 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants