Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for SRI/CORS in CSS files #406

Closed
fulldecent opened this issue Mar 17, 2017 · 1 comment · Fixed by #413
Closed

Check for SRI/CORS in CSS files #406

fulldecent opened this issue Mar 17, 2017 · 1 comment · Fixed by #413
Assignees

Comments

@fulldecent
Copy link
Collaborator

html-proofer currently checks for SRI/CORS attributes in Javascript links.

It should also do this for stylesheet links.

This is NOT a new command-line option. This is correcting the behavior of the current --check-sri option to match behavior as documented.


We can duplicate work for scripts here: https://github.com/gjtorikian/html-proofer/pull/388/files

Here is where scripts are checked: https://github.com/ilyalyo/html-proofer/blob/0cc1e95fcb86e505ad27614299f184aade44e5a2/lib/html-proofer/check/scripts.rb

Here is where we want links to be checked: https://github.com/ilyalyo/html-proofer/blob/0cc1e95fcb86e505ad27614299f184aade44e5a2/lib/html-proofer/check/links.rb

@fulldecent
Copy link
Collaborator Author

Please release 3.6.1 with this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants