-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a separate directory to search for the "Links" check? #139
Comments
Wow, I hadn't expected this, but you're absolutely right: https://travis-ci.org/gjtorikian/html-proofer/builds/46231488 I'll dig into fixing this as soon as I can. |
@csu Actually I goofed above, I had the file name wrong, and the zip file is correctly detected: https://travis-ci.org/gjtorikian/html-proofer/builds/46232517 Could you tell me more about your link setup? A repo or some CI output would be uber-helpful. |
I'm in a Jekyll repository. An HTML file in
My rake test: require 'html/proofer'
module HTML
class Proofer
def get_checks
%w{Links Scripts}
end
end
end
task :test do
sh "bundle exec jekyll build"
HTML::Proofer.new("./_site", {:href_ignore => ['www.facebook.com']}).run
end |
Couple of things:
|
Yeah, that link is correct. I was writing it from memory. I just checked and the file doesn't appear in the assets folder within |
I think that may be so. I think it's entirely possible to "jail" html-proofer, though--that is, if you refer to a link outside of your served directory, I think that should count as a failure (with a configurable option). For example, let's say you're checking _site. You can absolutely have a link that's valid, locally, to Given that, I'll keep this issue open as something to work on. |
HTMLProofer 3.0 was just released, and this might be fixed with the new |
I'm getting failures for links of the format
/something/something/file.zip
. I'm running checks on files in_site/
, but Jekyll also includes the folders/files in the parent directory. Is there any way to include those in the "Link" check?The text was updated successfully, but these errors were encountered: