Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate .com.de domains #520

Open
1 task done
funnymomo opened this issue Jan 5, 2025 · 8 comments
Open
1 task done

Validate .com.de domains #520

funnymomo opened this issue Jan 5, 2025 · 8 comments

Comments

@funnymomo
Copy link

funnymomo commented Jan 5, 2025

📜 Description

Looks like "com.de" domain is missing from the list of two level domains

As a result, when enabled "xxx.com.de" domain, the login stopped working. It worked when I was using localhost.

(

export const allTwoLevelSubdomain = [
)

👟 Reproduction steps

Enable a .com.de domain on top of your deployment and try to login. User is taken back to the login screen.

👍 Expected behavior

User should be able to log in.

👎 Actual Behavior with Screenshots

After entering the correct user/pass on a xxx.com.de domain, user is taken back to login screen. This does not happen when using localhost.

💻 Operating system

Windows

🤖 Node Version

Latest Docker Image

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

@funnymomo
Copy link
Author

I can submit a PR if it helps.

@nevo-david
Copy link
Contributor

Go for it @funnymomo

@jamesread jamesread changed the title Give your bug report a good title Validate .com.de domains Jan 6, 2025
@funnymomo
Copy link
Author

@nevo-david : Sure, Can you please share the steps on how to proceed.

@mbi001
Copy link

mbi001 commented Jan 6, 2025

@funnymomo is it possible that you add as well .ddns.net domain aswell ??

@funnymomo
Copy link
Author

@nevo-david : I created the pull request. I am doing this for the first time so apologies if I did any mistakes.

#532

@mbi001
Copy link

mbi001 commented Jan 6, 2025

@nevo-david : I created the pull request. I am doing this for the first time so apologies if I did any mistakes.

#532

Hi
I have created PR that corrects both .com.de. And ddns.net #531

So we could close #532

As #531 cover both

@UnluckyForSome
Copy link

Can we also add .synology.me?

@mbi001
Copy link

mbi001 commented Jan 7, 2025

Can we also add .synology.me?

I have added the.synology.me to the PR #531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants