-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate .com.de domains #520
Comments
I can submit a PR if it helps. |
Go for it @funnymomo |
@nevo-david : Sure, Can you please share the steps on how to proceed. |
@funnymomo is it possible that you add as well .ddns.net domain aswell ?? |
@nevo-david : I created the pull request. I am doing this for the first time so apologies if I did any mistakes. |
Hi So we could close #532 As #531 cover both |
Can we also add .synology.me? |
I have added the.synology.me to the PR #531 |
📜 Description
Looks like "com.de" domain is missing from the list of two level domains
As a result, when enabled "xxx.com.de" domain, the login stopped working. It worked when I was using localhost.
(
postiz-app/libraries/helpers/src/subdomain/all.two.level.subdomain.ts
Line 1 in 92b8feb
👟 Reproduction steps
Enable a .com.de domain on top of your deployment and try to login. User is taken back to the login screen.
👍 Expected behavior
User should be able to log in.
👎 Actual Behavior with Screenshots
After entering the correct user/pass on a xxx.com.de domain, user is taken back to login screen. This does not happen when using localhost.
💻 Operating system
Windows
🤖 Node Version
Latest Docker Image
📃 Provide any additional context for the Bug.
No response
👀 Have you spent some time to check if this bug has been raised before?
Are you willing to submit PR?
Yes I am willing to submit a PR!
The text was updated successfully, but these errors were encountered: