Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing assert in test_base.py #101

Closed
Sjord opened this issue Oct 17, 2023 · 1 comment · Fixed by #109
Closed

Missing assert in test_base.py #101

Sjord opened this issue Oct 17, 2023 · 1 comment · Fixed by #109
Labels
acknowledged help wanted

Comments

@Sjord
Copy link

Sjord commented Oct 17, 2023

gitdb/gitdb/test/test_base.py at master · gitpython-developers/gitdb

istream.size = s * 2
istream.size == s * 2

istream.size == s * 2 doesn't do anything. It should probably be assert istream.size == s * 2.
@Byron
Copy link
Member

Byron commented Oct 17, 2023

Thanks! Please feel free to submit a PR as well.

@Clavss Clavss mentioned this issue Dec 8, 2023
Merged
@Byron Byron closed this as completed in #109 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing asserts in test_base.py
2 participants
@Byron @Sjord