-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support limited use of the HTML 'style' attribute #486
Comments
Agreed! |
+1 |
1 similar comment
+1 |
This library only performs the conversion to markup and does not perform the HTML sanitization. See https://github.com/github/markup#readme for more information on how READMEs are rendered. |
The readme of this library says that the 'HTML is sanitized'. It is unclear about this being done by another library, hence my confusion. But indeed, I now see that the sanitization filter actually comes from jch/html-pipeline. I reposted this issue on jch/html-pipeline. Please feel free to now subscribe to that issue instead. |
This library is still not responsible for sanitisation; it should still go to the support team as a feature request. |
I've seen a number of specific feature requests about styling, such as this one about color. But surprisingly, I could find none regarding the actual HTML
style
attribute.That attribute is currently disallowed by the sanitization filter. I agree that full use of the
style
attribute would be too powerful - positioning and sizing properties might mess up the whole layout.I propose that a 'css whitelist' is created, allowing limited use of the
style
attribute. I'm sure many developers would like to be able to usecolor
,border
,padding
, and so on, to improve the style of their documentation.The text was updated successfully, but these errors were encountered: