Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support limited use of the HTML 'style' attribute #486

Closed
mhelvens opened this issue Apr 9, 2015 · 7 comments
Closed

Support limited use of the HTML 'style' attribute #486

mhelvens opened this issue Apr 9, 2015 · 7 comments

Comments

@mhelvens
Copy link

mhelvens commented Apr 9, 2015

I've seen a number of specific feature requests about styling, such as this one about color. But surprisingly, I could find none regarding the actual HTML style attribute.

That attribute is currently disallowed by the sanitization filter. I agree that full use of the style attribute would be too powerful - positioning and sizing properties might mess up the whole layout.

I propose that a 'css whitelist' is created, allowing limited use of the style attribute. I'm sure many developers would like to be able to use color, border, padding, and so on, to improve the style of their documentation.

@Timoses
Copy link

Timoses commented Apr 14, 2015

Agreed!

@haneefmubarak
Copy link

+1

1 similar comment
@pdipietro
Copy link

+1

@bkeepers
Copy link
Contributor

This library only performs the conversion to markup and does not perform the HTML sanitization. See https://github.com/github/markup#readme for more information on how READMEs are rendered.

@mhelvens
Copy link
Author

The readme of this library says that the 'HTML is sanitized'. It is unclear about this being done by another library, hence my confusion. But indeed, I now see that the sanitization filter actually comes from jch/html-pipeline.

I reposted this issue on jch/html-pipeline. Please feel free to now subscribe to that issue instead.

@ghost
Copy link

ghost commented Nov 15, 2018

@kivikakk, since youve done this:

11a355b

can we reopen this issue?

@kivikakk
Copy link
Contributor

This library is still not responsible for sanitisation; it should still go to the support team as a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants