From 570ca648570e7a6ee90e8d68e4ad97e78cfb86b6 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Mon, 3 Feb 2025 13:55:42 -0500 Subject: [PATCH 1/3] Don't flag ul with role='list' --- lib/configs/react.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/configs/react.js b/lib/configs/react.js index f5b29829..15b67dfb 100644 --- a/lib/configs/react.js +++ b/lib/configs/react.js @@ -36,6 +36,7 @@ module.exports = { nav: ['navigation'], // default in eslint-plugin-jsx-a11y tbody: ['rowgroup'], thead: ['rowgroup'], + ul: ['list'] // In webkit, setting list-style-type: none results in semantics being removed. Need for explicit role. }, ], }, From 9e465e8748e5d7c7662f1037819dd89585580a9c Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Mon, 3 Feb 2025 14:00:37 -0500 Subject: [PATCH 2/3] update comma --- lib/configs/react.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/configs/react.js b/lib/configs/react.js index 15b67dfb..7894ae62 100644 --- a/lib/configs/react.js +++ b/lib/configs/react.js @@ -36,7 +36,7 @@ module.exports = { nav: ['navigation'], // default in eslint-plugin-jsx-a11y tbody: ['rowgroup'], thead: ['rowgroup'], - ul: ['list'] // In webkit, setting list-style-type: none results in semantics being removed. Need for explicit role. + ul: ['list'], // In webkit, setting list-style-type: none results in semantics being removed. Need for explicit role. }, ], }, From e5b0378d9febfe02828411cbddedc0b6e084f653 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:02:21 -0500 Subject: [PATCH 3/3] Update lib/configs/react.js Co-authored-by: Joyce Zhu --- lib/configs/react.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/configs/react.js b/lib/configs/react.js index 7894ae62..6667f597 100644 --- a/lib/configs/react.js +++ b/lib/configs/react.js @@ -36,7 +36,7 @@ module.exports = { nav: ['navigation'], // default in eslint-plugin-jsx-a11y tbody: ['rowgroup'], thead: ['rowgroup'], - ul: ['list'], // In webkit, setting list-style-type: none results in semantics being removed. Need for explicit role. + ul: ['list'], // In webkit, setting list-style-type: none results in semantics being removed. Need explicit role. }, ], },