Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minmax should allow fr #118

Closed
lukashambsch opened this issue Feb 22, 2019 · 2 comments
Closed

minmax should allow fr #118

lukashambsch opened this issue Feb 22, 2019 · 2 comments

Comments

@lukashambsch
Copy link

The minmax attribute should let you use fr.

I'm currently getting this error:

gridTemplateColumns([
  13 ┆   `repeat((`autoFit, `minmax((px(150), fr(1.))))),
  14 ┆ ]),
  15 ┆ gridGap(px(12)),

  This has type:
    [> `fr(float) ]
  But somewhere wanted:
    Css.length
  The second variant type does not allow tag(s) `fr
@JakubMarkiewicz
Copy link
Contributor

I can take this

@JakubMarkiewicz JakubMarkiewicz mentioned this issue Mar 16, 2019
Merged
@giraud
Copy link
Owner

giraud commented Mar 20, 2019

Fixed in 8.0.3

@giraud giraud closed this as completed Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giraud @lukashambsch @JakubMarkiewicz