Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise NETStandard.Library version to 2.0.3 #400

Closed
wants to merge 1 commit into from

Conversation

slang25
Copy link
Member

@slang25 slang25 commented Feb 10, 2020

Relates to discussion in #398

With the sample app, the project.assets.json file (a sort of transient paket.lock for nuget) drops from 4830 lines vs 1300 lines.

A downside to this is:

  • It's weird to have to do this
  • We get a compiler warning in the Giraffe project that is hard to suppress

I'm not convinced we should merge this, I think the real solution is to press on with a 2.2.0 TaskBuilder.fs, or migrate to ply.

@slang25 slang25 mentioned this pull request Feb 10, 2020
@dustinmoris
Copy link
Member

Agree this feels like an unnecessary hack. TaskBuilder already has the change in an alpha release so we should just push for the proper release there or we could release a pre-release of Giraffe with the pre-release of TaskBuilder for those who can't wait.

Copy link
Member

@dustinmoris dustinmoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should restrain from merging this.

@slang25
Copy link
Member Author

slang25 commented Feb 11, 2020

Agreed 👍

@slang25 slang25 closed this Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants