Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Dependencies #398

Merged
merged 7 commits into from
Feb 11, 2020
Merged

Reduced Dependencies #398

merged 7 commits into from
Feb 11, 2020

Conversation

dustinmoris
Copy link
Member

I'm proposing to release a new version of Giraffe with these fewer dependencies which are not required for netcore3.0 anymore and which cause some Paket issues for users according to Isaac Abraham who maintains the SAFE stack.

Any objections?

@dustinmoris dustinmoris changed the title Develop Reduced Dependencies Feb 9, 2020
@slang25
Copy link
Member

slang25 commented Feb 9, 2020

I talked to Isaac about this, my feeling are we should release these changes, but it won't really have much effect, the biggest gain to be had is getting a release version of TaskBuilder.fs, see here:
rspeele/TaskBuilder.fs#29

@forki
Copy link
Contributor

forki commented Feb 10, 2020

@dustinmoris no objections. Please release and when @rspeele releases the new task builder then the whole ecosystem can release a new wave.

@isaacabraham
Copy link
Contributor

@slang25 actually, these changes have a bigger impact in terms of e.g. paket lock files than the task builder (which at least is already available as an alpha).

@slang25
Copy link
Member

slang25 commented Feb 10, 2020

@isaacabraham Ah, I realise what's going on here.

You are absolutely right, Paket does the right thing here, the problem is if you are not using paket, dotnet restore (nuget) will pick NETStandard.Library 1.6.1 rather than 2.0.3, and it's a complete mess.

@slang25
Copy link
Member

slang25 commented Feb 10, 2020

Perhaps Giraffe should explicitly lift NETStandard.Library as it is a known transitive dependency. I feel a PR coming.

@slang25
Copy link
Member

slang25 commented Feb 10, 2020

PR created here, not sure it's the right thing though #400

@dustinmoris dustinmoris merged commit 41d6c43 into master Feb 11, 2020
@isaacabraham
Copy link
Contributor

@slang25 @dustinmoris any chance this could get released? it would really help with the getting started experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants