Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MPI capability to Ginkgo #931

Closed
wants to merge 43 commits into from
Closed

Add MPI capability to Ginkgo #931

wants to merge 43 commits into from

Conversation

pratikvn
Copy link
Member

This PR adds MPI capability to Ginkgo.

Most of the discussion has happened here: #908

As this capability is completely independent, it can be merged into develop without any conflicts.

pratikvn and others added 30 commits November 20, 2021 21:13
@pratikvn
Add MPI layer CMake setup
ddb1933
@pratikvn
Add basic classes and hooks
7e1a4b9
@pratikvn
Update with MPI version
a56a6ff
@pratikvn
Add a EnableSharedCreate interface
426e48b
@pratikvn
Add new macros for instantiations
a76b727
@pratikvn
Add exception handling and helpers
0e8a031
@pratikvn
Add MPI bindings and binding helpers
bdb5f87
@pratikvn
Add MPI tests and CUDA Aware check helper
4f5db6b
@pratikvn
Add a few MPI jobs for CI
7ba1c81
@pratikvn
Add docs, and some tests.
4e869f6
@pratikvn
Review update, more tests
da8f2c4
@pratikvn
Add an example as an integration test
13d1c53
@pratikvn
Disable MPI compilation when not being used.
91aadba
@pratikvn
Fix test_install and MPI run as root
518be63
@pratikvn
Make init_finalize a singleton
64bd141
@pratikvn
Review WIP
320ab30
@pratikvn
Review update 2: comm, req, and win
09ff8f5
@pratikvn
WIP: Moving funcs to public header
ff15e67
@pratikvn
Move all wrappers to headers
3a6d2df
@pratikvn
Update init_finalize
25d5e62
@pratikvn
Remove ginkgo_mpi library, move to core
8544262
@ginkgo-bot @pratikvn
Format files
fb95689 
Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
@pratikvn
Rem unnecessary ex and code in gtest-mpi-listener
fcdcb79
@ginkgo-bot @pratikvn
Format files
06a4f36 
Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
@pratikvn @upsj
Library fixes and gtes-mpi-listener updates
4f5ae1d 
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
@pratikvn
Some more fixes for cmake and MPI types
c0a82cb
@pratikvn
Remove init finalize exception handling.
1b148ec
@pratikvn
Make nb functions return requests
7f2cd88
@pratikvn
Some test updates
cf965ad
@pratikvn
Update tests to TYPED_TESTS
1c681bb
pratikvn and others added 11 commits November 20, 2021 21:13
@pratikvn
Make MPI calls inline
b377bec
@pratikvn
Overhaul communicator
0b9a510
@pratikvn
Fix MPI_Win, MPI_Put consistency issues
7d11a47
@pratikvn
Fix GPU Aware functionality
df080b6
@pratikvn
Update docs and fix types
b1c264d
@pratikvn
Make sync a comm member function
ced2a61
@pratikvn @Slaedr @upsj
Review update.
4ecb5a1 
Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
@pratikvn
Store MPI_Comm in a shared_ptr
c2d9679
@pratikvn
Move everything to member funcs of comm and window
509ca6c
@pratikvn
Add request and status wrappers
e913f55
@pratikvn @upsj
@MarcelKoch @Slaedr
Review updates.
37b8a44 
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Aditya Kashi <aditya.kashi@kit.edu>
@pratikvn pratikvn added is:new-feature A request or implementation of a feature that does not exist yet. 1:ST:ready-to-merge This PR is ready to merge. mod:mpi This is related to the MPI module type:distributed-functionality labels Nov 29, 2021
@pratikvn pratikvn added this to the Ginkgo 1.5.0 milestone Nov 29, 2021
@pratikvn pratikvn requested a review from a team November 29, 2021 11:35
@pratikvn pratikvn self-assigned this Nov 29, 2021
@ginkgo-bot ginkgo-bot added mod:core This is related to the core module. reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. reg:testing This is related to testing. labels Nov 29, 2021
@upsj
Copy link
Member

upsj commented Nov 29, 2021

Maybe instead merge distributed-develop into develop after #909 has been merged into it?

@pratikvn
Copy link
Member Author

Yeah, we could, I wanted to avoid the merge commits, which might be unnecessary.

@pratikvn
Copy link
Member Author

Superseded by #932

@pratikvn pratikvn closed this Nov 29, 2021
@pratikvn pratikvn deleted the mpi-bindings branch November 29, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pratikvn pratikvn

Labels
1:ST:ready-to-merge This PR is ready to merge. is:new-feature A request or implementation of a feature that does not exist yet. mod:core This is related to the core module. mod:mpi This is related to the MPI module reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. reg:testing This is related to testing. type:distributed-functionality
Projects
None yet
Milestone
Ginkgo 1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pratikvn @upsj @ginkgo-bot