-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check config key #1792
Open
yhmtsai
wants to merge
6
commits into
develop
Choose a base branch
from
check_config_key
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Check config key #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ea21ad
to
ec6eda5
Compare
ec6eda5
to
91c9732
Compare
Error: The following files need to be formatted:
You can find a formatting patch under Artifacts here or run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:ready-for-review
This PR is ready for review
mod:core
This is related to the core module.
reg:testing
This is related to testing.
type:solver
This is related to the solvers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the check to verify the keys in config are allowed by predefined keys set.
typo in config is quite easy in the file because we do not have auto-complete for that
It avoids typo or misusage of parameters from user such that the configuring solver is not what users expect without notice.
Isome thoughts will be nice.
allowed_keys
preparation: predefine it as early as possible or insert the key into the set close to the conditionI am predefining it as early as possible. but I think the second way might makes sense when the class has long list of keys like multigrid. It makes the manual type together and reduce the chance that missing deleting one of condition and allowed key. The first one is somehow easy to set with constructor not many lines of
set.insert("key")