Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken run dispatch for smart pointers #1525

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix broken run dispatch for smart pointers #1525

merged 1 commit into from
Jan 12, 2024

Conversation

MarcelKoch
Copy link
Member

My last merge #1435 broke run (but somehow not for all compilers?). This should be the fix for it.

@MarcelKoch MarcelKoch self-assigned this Jan 11, 2024
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label Jan 11, 2024
@MarcelKoch MarcelKoch requested a review from a team January 11, 2024 15:18
@MarcelKoch MarcelKoch added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Jan 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarcelKoch MarcelKoch merged commit 9baa780 into develop Jan 12, 2024
13 of 14 checks passed
@MarcelKoch MarcelKoch deleted the fix-run-dispatch branch January 12, 2024 07:40
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

@tcojean tcojean tcojean approved these changes

Assignees

@MarcelKoch MarcelKoch

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:run-full-test mod:core This is related to the core module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarcelKoch @pratikvn @yhmtsai @tcojean @upsj @ginkgo-bot