Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reduce_over_group for new Intel SYCL versions #1524

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix reduce_over_group for new Intel SYCL versions #1524

merged 1 commit into from
Jan 9, 2024

Conversation

pratikvn
Copy link
Member

@pratikvn pratikvn commented Jan 9, 2024

This PR fixes an issue with the sycl::reduce_over_group for new Intel SYCL versions. This is required for compilation on Aurora.

@pratikvn pratikvn added 1:ST:WIP This PR is a work in progress. Not ready for review. mod:dpcpp This is related to the DPC++ module. labels Jan 9, 2024
@pratikvn pratikvn self-assigned this Jan 9, 2024
upsj
upsj approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pratikvn pratikvn added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:no-changelog-entry Skip the wiki check for changelog update is:confirmed Someone confirmed this issue. is:bugfix This fixes a bug and removed 1:ST:WIP This PR is a work in progress. Not ready for review. labels Jan 9, 2024
@pratikvn pratikvn changed the title WIP: Fix reduce_over_group for new Intel SYCL versions Fix reduce_over_group for new Intel SYCL versions Jan 9, 2024
@pratikvn
Copy link
Member Author

pratikvn commented Jan 9, 2024

Looks like the older Intel SYCL versions are also happy with this. So, I will merge this once the CI completes.

@pratikvn pratikvn merged commit 2033f10 into develop Jan 9, 2024
13 of 14 checks passed
@pratikvn pratikvn deleted the fix-sycl-subgroup branch January 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

Assignees

@pratikvn pratikvn

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. is:bugfix This fixes a bug is:confirmed Someone confirmed this issue. mod:dpcpp This is related to the DPC++ module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratikvn @upsj @MarcelKoch @yhmtsai