Automatically use current year for license #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsj
approved these changes
Jan 8, 2024
|
This also means that the updates to the license will be staggered (i.e. the year in a file is the year it changed last) which I'm totally fine with, but we should note it. |
|
@upsj we can still update all files yearly. With this change we just don't need to update the pre-commit config each year. |
|
I know, I'm just not sure if this is necessary, since the date is supposed to describe when the code was written, so it's fine to leave it unchanged on old files. No strong opinion on either solution though. |
ee6fad7 to
f53992a
Compare
|
Error: PR already merged! |
1 similar comment
|
Error: PR already merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @tcojean suggestion, this now uses the current year for the license. The documentation of reuse is not helpful here, since it doesn't clearly describe that it will use the current year if the
--yearoption is not given.