Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Ell batched matrix format, kernels and tests #1416
Add a Ell batched matrix format, kernels and tests #1416
Changes from all commits
75ed67f
d3b8ad1
658a5af
1c3c5ff
c5a14c0
174c3fd
f4168f9
7cb4c51
88b6e3a
b78c0cc
4179654
6d16d3b
40741cb
b15308f
4b1fbc1
d231ca6
48e94bb
0949431
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
global function is only needed in matrix, right?
the other solver will use device function.
I am thinking of moving the
__global__
to the corresponding launcherThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends on what you see as a kernel and what as a launcher. To me
__global__
is a kernel, but indeed what you say is true that it does not need to be in the device kernel file and will probably not be used in the solvers. But I think maybe we can re-organize that later.