Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake Modules install location #1181

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Fix CMake Modules install location #1181

merged 1 commit into from
Nov 4, 2022

Conversation

upsj
Copy link
Member

@upsj upsj commented Nov 4, 2022

install(DIRECTORY ...) works differently dependent on whether the directory to be installed ends in a slash. The missing slash leads to the modules being installed in Modules/Modules

Fixes #1152

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Nov 4, 2022
@upsj upsj added this to the Ginkgo 1.5.0 milestone Nov 4, 2022
@upsj upsj self-assigned this Nov 4, 2022
@ginkgo-bot ginkgo-bot added the reg:build This is related to the build system. label Nov 4, 2022
@upsj upsj requested review from tcojean and a team November 4, 2022 10:40
tcojean
tcojean approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@tcojean tcojean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sneaky, thanks!

@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Nov 4, 2022
@upsj upsj added the 1:ST:high-importance This issue/PR is of high importance and must be addressed as soon as possible. label Nov 4, 2022
@upsj
Copy link
Member Author

upsj commented Nov 4, 2022

rebase!

@upsj upsj merged commit b3490f4 into develop Nov 4, 2022
@upsj upsj deleted the module_install_path branch November 4, 2022 19:27
@ginkgo-bot
Copy link
Member

Error: PR already merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@tcojean tcojean tcojean approved these changes

Assignees

@upsj upsj

Labels
1:ST:high-importance This issue/PR is of high importance and must be addressed as soon as possible. 1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system.
Projects
None yet
Milestone
Ginkgo 1.5.0
Development

Successfully merging this pull request may close these issues.

CMake modules get installed to a wrong path
4 participants
@upsj @ginkgo-bot @pratikvn @tcojean