-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified tests #1117
Unified tests #1117
Changes from 27 commits
aaa4c73
70352bb
cd89d8d
718b2fd
f37aae7
e0d0704
14e2f35
fd9a9d5
cacc17b
738c5c6
f5ad1b9
99ab195
eb8c320
0190764
ab3f23d
7eb52b5
057e235
fa338e3
fe0a77b
3e6e03c
60d8531
2ba3f88
8af2dc7
ef2b32f
3dadd5c
e8b73a2
a8b7e69
5a0f4f5
d0206b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -34,6 +34,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||||
#define GKO_CORE_TEST_UTILS_HPP_ | ||||||
|
||||||
|
||||||
#include <cmath> | ||||||
#include <complex> | ||||||
#include <initializer_list> | ||||||
#include <limits> | ||||||
|
@@ -189,7 +190,8 @@ struct reduction_factor { | |||||
using nc_output = remove_complex<OutputType>; | ||||||
using nc_precision = remove_complex<Precision>; | ||||||
static constexpr nc_output value{ | ||||||
std::numeric_limits<nc_precision>::epsilon() * nc_output{10}}; | ||||||
std::numeric_limits<nc_precision>::epsilon() * nc_output{10} * | ||||||
(gko::is_complex<Precision>() ? nc_output{1.4142} : one<nc_output>())}; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is sqrt(2) right? So why not
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice suggestion, thanks! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unfortunately this doesn't work, because it needs to be constexpr |
||||||
}; | ||||||
|
||||||
|
||||||
|
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, though it was surprisingly complicated to get that value in there, so I hand-wrote it