Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-munsafe-fp-atomics argument unused warning for HIP #1186

Closed
yhmtsai opened this issue Nov 6, 2022 · 1 comment
Closed

-munsafe-fp-atomics argument unused warning for HIP #1186

yhmtsai opened this issue Nov 6, 2022 · 1 comment

Comments

@yhmtsai
Copy link
Member

yhmtsai commented Nov 6, 2022

In #1091, we adds the unsafe-fp-atomic into our compilation.
Although HIP should support it after 5, but its shipped clang might not support it yet and throw the unused warning.

We could handle it like https://cmake.org/cmake/help/latest/module/CheckCXXCompilerFlag.html
Try using hip to compile a dummy program with the flag and check whether it throws any warning.

@upsj
Copy link
Member

upsj commented Oct 15, 2023

fixed by #1409

@upsj upsj closed this as completed Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants