Review update

Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
ginkgo-project · Apr 4, 2022 · 7d2fa04 · 7d2fa04
1 parent de6e23c
commit 7d2fa04
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/include/ginkgo/core/multigrid/fixed_coarsening.hpp b/include/ginkgo/core/multigrid/fixed_coarsening.hpp
@@ -86,7 +86,8 @@ class FixedCoarsening
     GKO_CREATE_FACTORY_PARAMETERS(parameters, Factory)
     {
         /**
-         * The coarse rows to be selected in the coarse matrix.
+         * This array specifies the rows of the fine matrix which should be
+         * selected as rows for the coarse matrix.
          */
         Array<IndexType> GKO_FACTORY_PARAMETER_VECTOR(coarse_rows, nullptr);
 

diff --git a/test/multigrid/fixed_coarsening_kernels.cpp b/test/multigrid/fixed_coarsening_kernels.cpp
@@ -171,11 +171,9 @@ TEST_F(FixedCoarsening, GenerateMgLevelIsEquivalentToRef)
     auto d_mg_level = d_mg_level_factory->generate(d_system_mtx);
 
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_prolong_op()),
-                        gko::as<Csr>(mg_level->get_prolong_op()),
-                        r<value_type>::value);
+                        gko::as<Csr>(mg_level->get_prolong_op()), 0.0);
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_restrict_op()),
-                        gko::as<Csr>(mg_level->get_restrict_op()),
-                        r<value_type>::value);
+                        gko::as<Csr>(mg_level->get_restrict_op()), 0.0);
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_coarse_op()),
                         gko::as<Csr>(mg_level->get_coarse_op()),
                         r<value_type>::value);
@@ -190,23 +188,19 @@ TEST_F(FixedCoarsening, GenerateMgLevelIsEquivalentToRefOnUnsortedMatrix)
     auto mg_level_factory =
         gko::multigrid::FixedCoarsening<value_type, int>::build()
             .with_coarse_rows(coarse_rows)
-            .with_skip_sorting(true)
             .on(ref);
     auto d_mg_level_factory =
         gko::multigrid::FixedCoarsening<value_type, int>::build()
             .with_coarse_rows(d_coarse_rows)
-            .with_skip_sorting(true)
             .on(exec);
 
     auto mg_level = mg_level_factory->generate(system_mtx);
     auto d_mg_level = d_mg_level_factory->generate(d_system_mtx);
 
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_prolong_op()),
-                        gko::as<Csr>(mg_level->get_prolong_op()),
-                        r<value_type>::value);
+                        gko::as<Csr>(mg_level->get_prolong_op()), 0.0);
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_restrict_op()),
-                        gko::as<Csr>(mg_level->get_restrict_op()),
-                        r<value_type>::value);
+                        gko::as<Csr>(mg_level->get_restrict_op()), 0.0);
     GKO_ASSERT_MTX_NEAR(gko::as<Csr>(d_mg_level->get_coarse_op()),
                         gko::as<Csr>(mg_level->get_coarse_op()),
                         r<value_type>::value);