Skip to content

Commit

Permalink
review updates
Browse files Browse the repository at this point in the history
Co-authored-by: Yuhsiang M. Tsai <yhmtsai@gmail.com>
  • Loading branch information
upsj and yhmtsai committed May 23, 2023
1 parent feb85e8 commit 722005b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/device_hooks/dpcpp_hooks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ namespace kernels {
namespace dpcpp {


void destroy_event(sycl::event* event) GKO_NOT_COMPILED(cuda);
void destroy_event(sycl::event* event) GKO_NOT_COMPILED(dpcpp);


} // namespace dpcpp
Expand Down
2 changes: 1 addition & 1 deletion core/device_hooks/hip_hooks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ namespace hip {
void reset_device(int device_id) GKO_NOT_COMPILED(hip);


void destroy_event(GKO_HIP_EVENT_STRUCT* event) GKO_NOT_COMPILED(cuda);
void destroy_event(GKO_HIP_EVENT_STRUCT* event) GKO_NOT_COMPILED(hip);


} // namespace hip
Expand Down
2 changes: 2 additions & 0 deletions include/ginkgo/core/base/timer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ class Timer {
*
* @param start the first time point (earlier)
* @param end the second time point (later)
*
* @return the difference between the time points in nanoseconds.
*/
virtual std::chrono::nanoseconds difference_async(
Expand All @@ -154,6 +155,7 @@ class Timer {
* kernels on the given executor.
*
* @param exec the executor to create a Timer for
*
* @return CpuTimer for ReferenceExecutor and OmpExecutor, CudaTimer for
* CudaExecutor, HipTimer for HipExecutor or DpcppTimer for
* DpcppExecutor.
Expand Down

0 comments on commit 722005b

Please sign in to comment.