review comments on tolerances

Co-authored-by: Pratik Nayak <pratikvn@protonmail.com>
ginkgo-project · Jan 10, 2022 · 23ec8c9 · 23ec8c9
1 parent 467a3fc
commit 23ec8c9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/cuda/test/matrix/identity.cpp b/cuda/test/matrix/identity.cpp
@@ -126,7 +126,7 @@ TEST_F(Identity, ScaleDenseAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), x.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dx.get());
 
-    GKO_ASSERT_MTX_NEAR(x, dx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(x, dx, r<vtype>::value);
 }
 
 
@@ -140,7 +140,7 @@ TEST_F(Identity, ScaleCsrAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), mtx.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dmtx.get());
 
-    GKO_ASSERT_MTX_NEAR(mtx, dmtx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(mtx, dmtx, r<vtype>::value);
 }
 
 

diff --git a/hip/test/matrix/identity.cpp b/hip/test/matrix/identity.cpp
@@ -126,7 +126,7 @@ TEST_F(Identity, ScaleDenseAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), x.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dx.get());
 
-    GKO_ASSERT_MTX_NEAR(x, dx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(x, dx, r<vtype>::value);
 }
 
 
@@ -140,7 +140,7 @@ TEST_F(Identity, ScaleCsrAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), mtx.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dmtx.get());
 
-    GKO_ASSERT_MTX_NEAR(mtx, dmtx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(mtx, dmtx, r<vtype>::value);
 }
 
 

diff --git a/omp/test/matrix/identity.cpp b/omp/test/matrix/identity.cpp
@@ -126,7 +126,7 @@ TEST_F(Identity, ScaleDenseAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), x.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dx.get());
 
-    GKO_ASSERT_MTX_NEAR(x, dx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(x, dx, r<vtype>::value);
 }
 
 
@@ -140,7 +140,7 @@ TEST_F(Identity, ScaleCsrAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), mtx.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dmtx.get());
 
-    GKO_ASSERT_MTX_NEAR(mtx, dmtx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(mtx, dmtx, r<vtype>::value);
 }
 
 

diff --git a/test/matrix/identity_kernels.cpp b/test/matrix/identity_kernels.cpp
@@ -139,7 +139,7 @@ TEST_F(Identity, ScaleDenseAddIdentity)
     id->apply(alpha.get(), id.get(), beta.get(), x.get());
     did->apply(dalpha.get(), did.get(), dbeta.get(), dx.get());
 
-    GKO_ASSERT_MTX_NEAR(x, dx, std::numeric_limits<vtype>::epsilon());
+    GKO_ASSERT_MTX_NEAR(x, dx, r<vtype>::value);
 }