From 0de0cccc67da9c2827730c2095da8fd0118707b1 Mon Sep 17 00:00:00 2001 From: Pratik Nayak Date: Wed, 23 Mar 2022 16:01:29 +0100 Subject: [PATCH] Review update Co-authored-by: Tobias Ribizel --- include/ginkgo/core/multigrid/fixed_coarsening.hpp | 3 ++- test/multigrid/fixed_coarsening_kernels.cpp | 14 ++++---------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/include/ginkgo/core/multigrid/fixed_coarsening.hpp b/include/ginkgo/core/multigrid/fixed_coarsening.hpp index 6dbb3beb036..40a0b6f780a 100644 --- a/include/ginkgo/core/multigrid/fixed_coarsening.hpp +++ b/include/ginkgo/core/multigrid/fixed_coarsening.hpp @@ -86,7 +86,8 @@ class FixedCoarsening GKO_CREATE_FACTORY_PARAMETERS(parameters, Factory) { /** - * The coarse rows to be selected in the coarse matrix. + * This array specifies the rows of the fine matrix which should be + * selected as rows for the coarse matrix. */ Array GKO_FACTORY_PARAMETER_VECTOR(coarse_rows, nullptr); diff --git a/test/multigrid/fixed_coarsening_kernels.cpp b/test/multigrid/fixed_coarsening_kernels.cpp index 47fadeaa6ac..6cd2931b093 100644 --- a/test/multigrid/fixed_coarsening_kernels.cpp +++ b/test/multigrid/fixed_coarsening_kernels.cpp @@ -171,11 +171,9 @@ TEST_F(FixedCoarsening, GenerateMgLevelIsEquivalentToRef) auto d_mg_level = d_mg_level_factory->generate(d_system_mtx); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_prolong_op()), - gko::as(mg_level->get_prolong_op()), - r::value); + gko::as(mg_level->get_prolong_op()), 0.0); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_restrict_op()), - gko::as(mg_level->get_restrict_op()), - r::value); + gko::as(mg_level->get_restrict_op()), 0.0); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_coarse_op()), gko::as(mg_level->get_coarse_op()), r::value); @@ -190,23 +188,19 @@ TEST_F(FixedCoarsening, GenerateMgLevelIsEquivalentToRefOnUnsortedMatrix) auto mg_level_factory = gko::multigrid::FixedCoarsening::build() .with_coarse_rows(coarse_rows) - .with_skip_sorting(true) .on(ref); auto d_mg_level_factory = gko::multigrid::FixedCoarsening::build() .with_coarse_rows(d_coarse_rows) - .with_skip_sorting(true) .on(exec); auto mg_level = mg_level_factory->generate(system_mtx); auto d_mg_level = d_mg_level_factory->generate(d_system_mtx); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_prolong_op()), - gko::as(mg_level->get_prolong_op()), - r::value); + gko::as(mg_level->get_prolong_op()), 0.0); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_restrict_op()), - gko::as(mg_level->get_restrict_op()), - r::value); + gko::as(mg_level->get_restrict_op()), 0.0); GKO_ASSERT_MTX_NEAR(gko::as(d_mg_level->get_coarse_op()), gko::as(mg_level->get_coarse_op()), r::value);