HTTP2/Push

[SCKelemen]

Is it possible to use Http2/push with gin?

func pushHandler(c *gin.Context) {

	if pusher, ok := c.Writer.(http.Pusher); ok {
		if err := pusher.Push("/app.css", nil); err != nil {
                    // log error
		}
	}
	c.Status(http.StatusOK)
}

I would like to be able to use http2/push with router.StaticFile(). Is it possible to configure this to push the linked assets, or would I have to manually handle the endpoint?

router.StaticFile("/index.html", "../public/index.html")

router := gin.Default()
router.GET("/index", indexHandler)
router.Run()

func indexHandler(c *gin.Context) {
	if pusher, ok := c.Writer.(http.Pusher); ok {
		if err := pusher.Push("/style.css", nil); err != nil {

		}
               if err != nil { // if the first asset fails, there is no sense in pushing the others
                   pusher.Push("/favicon.png", nil)
                   pusher.Push("/app.js", nil)
               }

	}
        // send index bytes
	c.Status(http.StatusOK)
}

[htobenothing]

c.Writer is not a simple http.Response.Writer, for me is to add Pusher() function to get http.Pusher

type ResponseWriter interface {

	http.ResponseWriter
	http.Hijacker
	http.Flusher
	http.CloseNotifier

	// Returns the HTTP response status code of the current request.
	Status() int

	// Returns the number of bytes already written into the response http body.
	// See Written()
	Size() int

	// Writes the string into the response body.
	WriteString(string) (int, error)

	// Returns true if the response body was already written.
	Written() bool

	// Forces to write the http header (status code + headers).
	WriteHeaderNow()

	// return http.Pusher if support http2 push
	Pusher() http.Pusher
}

func (w *responseWriter) Pusher() http.Pusher {
	if pusher, ok := w.ResponseWriter.(http.ResponseWriter).(http.Pusher); ok {
		return pusher
	}
	return nil
}

router.GET("/pusher", func(c *gin.Context) {
     if pusher := c.Writer.Pusher(); pusher != nil {
      // pusher.Push() something
    }
}

[appleboy]

See #1273 PR

[appleboy]

Please update the latest code.