Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: gguf pypi package corrupts environment #9566

Closed
vladmandic opened this issue Sep 20, 2024 · 2 comments · Fixed by #11116
Closed

Bug: gguf pypi package corrupts environment #9566

vladmandic opened this issue Sep 20, 2024 · 2 comments · Fixed by #11116
Labels
bug Something isn't working help wanted Extra attention is needed high severity Used to report high severity bugs in llama.cpp (Malfunctioning hinder important workflow)

Comments

@vladmandic
Copy link

What happened?

installing gguf using pip install gguf will register gguf AND scripts
which means that any app that has scripts in their structure will suddenly start failing just because gguf is installed.

looking at https://github.com/ggerganov/llama.cpp/blob/master/gguf-py/pyproject.toml

packages = [
    {include = "gguf"},
    {include = "gguf/py.typed"},
    {include = "scripts"},
]

culprit is clear - scripts folder should be moved to be under gguf, not as a separate package.
if that is too much, then at least rename scripts package to be gguf_scripts

Name and Version

latest commit as of date of issue: d39e267

What operating system are you seeing the problem on?

Linux, Mac, Windows, BSD

Relevant log output

import gguf
from scripts import test_module

test_module.some_method()


```log
ImportError: cannot import name 'test_module' from 'scripts' (venv/lib/python3.12/site-packages/scripts/__init__.py)
@vladmandic vladmandic added bug-unconfirmed high severity Used to report high severity bugs in llama.cpp (Malfunctioning hinder important workflow) labels Sep 20, 2024
@github-actions github-actions bot added the stale label Oct 21, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Nov 4, 2024
@vladmandic
Copy link
Author

@ggerganov bot closed because nobody looked at confirmed and easily reproducible and easily solvable issue????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed high severity Used to report high severity bugs in llama.cpp (Malfunctioning hinder important workflow)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants