Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add OLMo November 2024 #10316

Closed
4 tasks done
2015aroras opened this issue Nov 15, 2024 · 0 comments · Fixed by #10394
Closed
4 tasks done

Feature Request: Add OLMo November 2024 #10316

2015aroras opened this issue Nov 15, 2024 · 0 comments · Fixed by #10394
Labels
enhancement New feature or request

Comments

@2015aroras
Copy link
Contributor

Prerequisites

  • I am running the latest code. Mention the version if possible as well.
  • I carefully followed the README.md.
  • I searched using keywords relevant to my issue to make sure that I am creating a new issue that is not already open (or closed).
  • I reviewed the Discussions, and have a new and useful enhancement to share.

Feature Description

Add support for the updated family of OLMo models will be released in November.

Motivation

It would be great to have llama.cpp support of the new OLMo models at release.

Possible Implementation

The new OLMo models has a few small architecture changes compared to the existing models:

  • RMSNorm is used instead of standard layer norm.
  • Norm is applied to attention queries and keys.
  • Norm is applied after attention/feedforward rather than before.

The PR for adding it to transformers is approved: huggingface/transformers#34551

@2015aroras 2015aroras added the enhancement New feature or request label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant