Possibly missing msg_send![..., retain] in wgpu-hal/src/metal/surface.rs

[jimblandy]

#2826 removed a retain message send from Surface::from_view that incremented the reference count on view, without adding back anything complementary (that I can see). There's nothing in that PR to suggest that the old retain call was incorrect, and indeed, the returned Surface holds a new pointer to the view, so this seems like a bug.

[jimblandy]

cc @jinleili

[jinleili]

Yes, you are right.
Since Surface's view field is only called in destroy_surface, wouldn't it be better to just remove the view field?

[jinleili]

Oops, still need view field on the iOS target.

[jimblandy]

@jinleili I think this is closed. If there's anything missing, please re-open and fill me in.