Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Tag all spans with thread info #153

Open
2 of 4 tasks
markushi opened this issue Oct 19, 2023 · 2 comments
Open
2 of 4 tasks

[EPIC] Tag all spans with thread info #153

markushi opened this issue Oct 19, 2023 · 2 comments

Comments

@markushi
Copy link
Member

markushi commented Oct 19, 2023

For mobile starfish we want to tag all spans, indicating if the ran on the main thread or not.
The main thread flag is determined in the moment the span was started (similar to otel).

See span data conventions https://develop.sentry.dev/sdk/performance/span-data-conventions/#thread on how to add this info.

Tasks

Preview Give feedback
  1. Platform: Android
    markushi
  2. Platform: Cocoa
    philipphofmann
  3. Platform: React-Native
  4. 9.0.0 Blocked Platform: Dart
@markushi markushi changed the title Tag spans with if they ran on the main thread or not [Starfish] Tag spans with if they ran on the main thread or not Oct 19, 2023
@markushi markushi changed the title [Starfish] Tag spans with if they ran on the main thread or not [Starfish] Tag all spans with main thread flag Oct 19, 2023
@philipphofmann philipphofmann changed the title [Starfish] Tag all spans with main thread flag [Starfish] Tag all spans with thread info Oct 20, 2023
@kahest kahest changed the title [Starfish] Tag all spans with thread info [EPIC] Tag all spans with thread info Nov 7, 2023
@krystofwoldrich
Copy link
Member

krystofwoldrich commented Jan 10, 2025

What for will this information be used in Sentry? RN has the JS (javascript) and UI (main) threads and both are of high importance for smooth user experience.


Is the thread.id optional?

@krystofwoldrich
Copy link
Member

Since there are no features depending on the names at the moment, RN will use javascript and main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Discussion
Development

No branches or pull requests

4 participants